Contributions past few months
Rubygems.org
Working on the big PR Expose rubygem reverse dependencies #945, I extracted some patches that can be included on master directly.
Use select instead of pluck for reverse_dependencies #962
I had performance issues with the reverse dependencies calls, and I found that comes from SQL that took most of the time.
On the model Rubygem
reverse dependencies was calculated by getting all IDs
from Version
with same rubygem_id
.
Simple solution is to use select
instead of pluck
, this will create one SQL
with a SELECT IN ...
.
Use each for link_to_page on rubygems#show #1014
Simple one, on the rubygems#show
template there is list of links, so using a
simple Array and public_send
introduced in Ruby 1.9.1.
Slop
Refactoring and updating validate-website
, had issue with RegexpOption
that used to work on 3.6 version of slop
.
inch
I had added exit status to inch and only for suggest, for continuous
integration. It will be released on 0.7.0
version, so it's not yet available.
sovereign
I like lint files and keep thing clean and consistent. I found ansible-lint really useful locally and on Travis-CI.
As you can see most of the fixes are « curl used in place of get_url module », «
tar used in place of unarchive module », « Git checkouts must contain explicit
version » and « rm used in place of argument state=absent to file module ». To
test that I did not add issues, I used the vagrant
provisioning and see
that no changes has been created.